chore: update disabled to enabled in DP configs by hopehadfield · Pull Request #5021 · redhat-developer/rhdh

hopehadfield · 2026-06-25T16:08:50Z

Description

Follow-up PR to #4937 to replace disabled: true/false with enabled: true/false in all CI configs, e2e test fixtures, and sample values files:

.ci/pipelines/value_files/*.yaml — all plugin configs
scripts/rhdh-openshift-setup/values.yaml
e2e-tests/playwright/utils/authentication-providers/yamls/dynamic-plugins-config.yaml
e2e-tests/playwright/utils/authentication-providers/rhdh-deployment.ts — plugin.disabled → plugin.enabled

Which issue(s) does this PR fix

Fixes https://redhat.atlassian.net/browse/RHIDP-14726

PR acceptance criteria

Please make sure that the following steps are complete:

GitHub Actions are completed and successful
Unit Tests are updated and passing
E2E Tests are updated and passing
Documentation is updated if necessary (requirement for new features)
Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

rhdh-qodo-merge · 2026-06-25T16:11:36Z

PR Summary by Qodo

Replace dynamic plugin disabled flags with enabled across configs and e2e fixtures
⚙️ Configuration changes 🧪 Tests 🕐 20-40 Minutes

Description

• Standardize dynamic plugin config flags from disabled to enabled across CI values files.
• Update OpenShift setup sample values to use enabled and align inline documentation.
• Adjust Playwright e2e fixtures and deployment helper to toggle plugins via enabled.

Diagram

graph TD
  cfg_ci["CI values files"] --> ci["CI pipelines"] --> loader["Dynamic plugin loader"]
  cfg_setup["OpenShift setup values"] --> loader
  cfg_e2e_yaml["E2E plugin fixture YAML"] --> e2e["Playwright e2e"]
  util_ts["RHDH deployment helper"] --> e2e --> loader

High-Level Assessment

The following are alternative approaches to this PR:

1. Support both `disabled` and `enabled` during a transition window

➕ Prevents breakages if any downstream config/fixture still uses disabled
➕ Allows staggered rollouts across repos/environments
➖ Adds ambiguity (conflicts if both keys are present)
➖ Requires extra validation/precedence rules and longer-term cleanup

2. Introduce schema validation (CI) for dynamic plugin entries

➕ Catches incorrect flags early (e.g., lingering disabled usage)
➕ Reduces future drift in sample/fixture files
➖ Extra CI wiring and maintenance overhead
➖ May require authoring/maintaining a JSONSchema or custom linter

Recommendation: Proceed with the PR’s direct replacement approach (it keeps configs consistent and matches the new expected field), but ensure the runtime/plugin-config parser either already accepts only enabled or has a clear deprecation path. If downstream configs exist outside this repo, consider a short compatibility period (accept both keys with a documented precedence) plus CI validation to prevent reintroducing disabled.

Files changed (9) +73 / -73

Tests (2) +7 / -7

rhdh-deployment.tsToggle dynamic plugins via 'enabled' in Playwright deployment helper +2/-2

Toggle dynamic plugins via 'enabled' in Playwright deployment helper
• Updates the helper to set 'plugin.enabled = enabled' instead of negating a 'disabled' field. Also changes newly created plugin entries to emit 'enabled: enabled', aligning test deployments with the updated config shape.
e2e-tests/playwright/utils/authentication-providers/rhdh-deployment.ts

dynamic-plugins-config.yamlUpdate Playwright plugin fixture YAML to 'enabled: false' +5/-5

Update Playwright plugin fixture YAML to 'enabled: false'
• Replaces 'disabled: true' with 'enabled: false' for all listed plugins, keeping the fixture’s default-off behavior unchanged while matching the new key.
e2e-tests/playwright/utils/authentication-providers/yamls/dynamic-plugins-config.yaml

Other (7) +66 / -66

diff-values_showcase-sanity-plugins.yamlSwitch dynamic plugin flags to 'enabled' for showcase sanity set +35/-35

Switch dynamic plugin flags to 'enabled' for showcase sanity set
• Replaces per-plugin 'disabled: true/false' with the equivalent 'enabled: false/true' values. Preserves existing on/off intent for each plugin while aligning with the new configuration key.
.ci/pipelines/value_files/diff-values_showcase-sanity-plugins.yaml

diff-values_showcase_AKS.yamlUpdate AKS showcase CI values to use 'enabled' +1/-1

Update AKS showcase CI values to use 'enabled'
• Migrates the dynamic plugin entry from 'disabled: false' to 'enabled: true' to match the new flag semantics.
.ci/pipelines/value_files/diff-values_showcase_AKS.yaml

diff-values_showcase_EKS.yamlUpdate EKS showcase CI values to use 'enabled' +1/-1

Update EKS showcase CI values to use 'enabled'
• Migrates the dynamic plugin entry from 'disabled: false' to 'enabled: true' to match the new flag semantics.
.ci/pipelines/value_files/diff-values_showcase_EKS.yaml

diff-values_showcase_GKE.yamlUpdate GKE showcase CI values to use 'enabled' +3/-3

Update GKE showcase CI values to use 'enabled'
• Replaces 'disabled' with 'enabled' for the OCM plugins (kept off) and for the scaffolder relation processor (kept on). Maintains the intended enablement behavior across GKE-specific values.
.ci/pipelines/value_files/diff-values_showcase_GKE.yaml

values_showcase-rbac.yamlRename 'disabled' to 'enabled' and update inline docs (RBAC values) +6/-6

Rename 'disabled' to 'enabled' and update inline docs (RBAC values)
• Updates documentation comments to refer to plugins that are "not enabled by default" and to describe the 'enabled' flag. Converts listed plugin entries from 'disabled: false' to 'enabled: true'.
.ci/pipelines/value_files/values_showcase-rbac.yaml

values_showcase.yamlRename 'disabled' to 'enabled' and update inline docs (showcase values) +9/-9

Rename 'disabled' to 'enabled' and update inline docs (showcase values)
• Updates documentation comments to describe 'enabled' rather than 'disabled'. Converts multiple plugin entries from 'disabled: false' to 'enabled: true' while preserving existing behavior.
.ci/pipelines/value_files/values_showcase.yaml

values.yamlSwitch OpenShift setup sample values and comments to 'enabled' +11/-11

Switch OpenShift setup sample values and comments to 'enabled'
• Updates inline documentation to describe plugins as not enabled by default and to document the 'enabled' flag. Converts active plugin entries and commented examples from 'disabled: false' to 'enabled: true'.
scripts/rhdh-openshift-setup/values.yaml

Signed-off-by: Hope Hadfield <hhadfiel@redhat.com>

rhdh-qodo-merge · 2026-06-25T16:16:26Z

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

codecov · 2026-06-25T16:18:02Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 54.77%. Comparing base (1de75ee) to head (77bc7da).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5021      +/-   ##
==========================================
- Coverage   55.39%   54.77%   -0.62%     
==========================================
  Files         122      110      -12     
  Lines        2365     2147     -218     
  Branches      540      541       +1     
==========================================
- Hits         1310     1176     -134     
+ Misses       1049      969      -80     
+ Partials        6        2       -4

Flag	Coverage Δ
rhdh	`54.77% <ø> (-0.62%)`	⬇️

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1de75ee...77bc7da. Read the comment docs.

🚀 New features to boost your workflow:

📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

github-actions · 2026-06-25T16:49:09Z

Image was built and published successfully. It is available at:

Signed-off-by: Hope Hadfield <hhadfiel@redhat.com>

github-actions · 2026-06-25T18:53:11Z

Image was built and published successfully. It is available at:

hopehadfield · 2026-06-25T19:09:45Z

/test ?

hopehadfield · 2026-06-25T19:11:21Z

/test e2e-aks-helm-nightly
/test e2e-eks-helm-nightly
/test e2e-gke-helm-nightly

Zaperex

/lgtm

sonarqubecloud · 2026-06-25T20:18:00Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

openshift-ci · 2026-06-25T20:44:13Z

@hopehadfield: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-ocp-helm	`77bc7da`	link	unknown	`/test e2e-ocp-helm`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Stop burning the 120s ingestion budget on HTTP/shape errors, drop nested expect.poll wrappers, and align CI lightspeed overrides with post-#5021 enabled:false so helm/auth nightlies fail for the right reason. Co-authored-by: Cursor <cursoragent@cursor.com>

Stop burning the 120s ingestion budget on HTTP/shape errors, drop nested expect.poll wrappers, and align CI lightspeed overrides with post-redhat-developer#5021 enabled:false so helm/auth nightlies fail for the right reason. Co-authored-by: Cursor <cursoragent@cursor.com>

openshift-ci Bot requested review from PatAKnight and kadel June 25, 2026 16:08

openshift-ci Bot added the needs-rebase label Jun 25, 2026

chore: update disabled to enabled in DP configs

03f6e7c

Signed-off-by: Hope Hadfield <hhadfiel@redhat.com>

hopehadfield force-pushed the replace-disabled branch from 3e00ac7 to 03f6e7c Compare June 25, 2026 16:16

openshift-ci Bot removed the needs-rebase label Jun 25, 2026

rhdh-qodo-merge Bot added documentation Tests Enhancement labels Jun 25, 2026

chore: bump cli-module-install-dynamic-plugins

77bc7da

Signed-off-by: Hope Hadfield <hhadfiel@redhat.com>

Zaperex approved these changes Jun 25, 2026

View reviewed changes

openshift-ci Bot assigned Zaperex Jun 25, 2026

openshift-ci Bot added the lgtm label Jun 25, 2026

hopehadfield merged commit 694cfce into redhat-developer:main Jun 25, 2026
25 checks passed

Navigation Menu

Uh oh!

chore: update disabled to enabled in DP configs - #5021

chore: update disabled to enabled in DP configs#5021
hopehadfield merged 2 commits into
redhat-developer:mainfrom
hopehadfield:replace-disabled

hopehadfield commented Jun 25, 2026

Uh oh!

rhdh-qodo-merge Bot commented Jun 25, 2026

Uh oh!

rhdh-qodo-merge Bot commented Jun 25, 2026

Uh oh!

codecov Bot commented Jun 25, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Jun 25, 2026

Uh oh!

github-actions Bot commented Jun 25, 2026

Uh oh!

hopehadfield commented Jun 25, 2026

Uh oh!

hopehadfield commented Jun 25, 2026

Uh oh!

Zaperex left a comment

Uh oh!

Uh oh!

sonarqubecloud Bot commented Jun 25, 2026

Uh oh!

openshift-ci Bot commented Jun 25, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

hopehadfield commented Jun 25, 2026

Description

Which issue(s) does this PR fix

PR acceptance criteria

How to test changes / Special notes to the reviewer

Uh oh!

rhdh-qodo-merge Bot commented Jun 25, 2026

PR Summary by Qodo

Uh oh!

rhdh-qodo-merge Bot commented Jun 25, 2026

Code Review by Qodo

Great, no issues found!

Uh oh!

codecov Bot commented Jun 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions Bot commented Jun 25, 2026

Uh oh!

github-actions Bot commented Jun 25, 2026

Uh oh!

hopehadfield commented Jun 25, 2026

Uh oh!

hopehadfield commented Jun 25, 2026

Uh oh!

Zaperex left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sonarqubecloud Bot commented Jun 25, 2026

Quality Gate passed

Uh oh!

openshift-ci Bot commented Jun 25, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

codecov Bot commented Jun 25, 2026 •

edited

Loading